DXR is a code search and navigation tool aimed at making sense of large projects. It supports full-text and regex searches as well as structural queries.

Header

Mercurial (409f3966645a)

VCS Links

Line Code
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36
/* This Source Code Form is subject to the terms of the Mozilla Public
 * License, v. 2.0. If a copy of the MPL was not distributed with this
 * file, You can obtain one at http://mozilla.org/MPL/2.0/. */

#include "ExplicitImplicitChecker.h"
#include "CustomMatchers.h"

void ExplicitImplicitChecker::registerMatchers(MatchFinder *AstMatcher) {
  AstMatcher->addMatcher(
      cxxConstructorDecl(
          isInterestingImplicitCtor(),
          ofClass(allOf(isConcreteClass(), decl().bind("class"))),
          unless(isMarkedImplicit()))
          .bind("ctor"),
      this);
}

void ExplicitImplicitChecker::check(const MatchFinder::MatchResult &Result) {
  // We've already checked everything in the matcher, so we just have to report
  // the error.

  const CXXConstructorDecl *Ctor =
      Result.Nodes.getNodeAs<CXXConstructorDecl>("ctor");
  const CXXRecordDecl *Declaration =
      Result.Nodes.getNodeAs<CXXRecordDecl>("class");

  FixItHint FixItHint =
      FixItHint::CreateInsertion(Ctor->getLocation(), "explicit ");
  diag(Ctor->getLocation(), "bad implicit conversion constructor for %0",
       DiagnosticIDs::Error)
      << Declaration->getDeclName();
  diag(Ctor->getLocation(),
       "consider adding the explicit keyword to the constructor",
       DiagnosticIDs::Note)
      << FixItHint;
}